Skip to content

Conversation

@alexr00
Copy link
Member

@alexr00 alexr00 commented Feb 10, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 10, 2026 09:14
@alexr00 alexr00 enabled auto-merge (squash) February 10, 2026 09:14
@alexr00 alexr00 self-assigned this Feb 10, 2026
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 10, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Issue/Pull Request overview tab titles to be shorter and more informative, and introduces dedicated Issue overview webview icons.

Changes:

  • Shorten initial webview panel titles from Issue/Pull Request #<n> to #<n>.
  • Add a shared buildPanelTitle helper to include a truncated item title in the tab caption.
  • Add light/dark Issue overview SVG icons and set them as the default panel icon.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/github/pullRequestOverview.ts Uses buildPanelTitle to include PR title in the panel/tab title.
src/github/issueOverview.ts Adds buildPanelTitle, updates Issue tab titles, and sets a default panel icon.
resources/icons/issue_webview.svg Adds light-theme Issue overview icon.
resources/icons/dark/issue_webview.svg Adds dark-theme Issue overview icon.
Comments suppressed due to low confidence (1)

src/github/issueOverview.ts:77

  • IssueOverviewPanel constructor now unconditionally reads iconSubpath.dark/light, but createOrShow still passes undefined as the last argument. With strictNullChecks disabled, this will compile but will throw at runtime when opening an Issue overview (cannot read properties of undefined). Remove the explicit undefined argument so the default icon paths apply, or make iconSubpath optional again and guard before using it.
			const title = `#${identity.number.toString()}`;
			panel = new IssueOverviewPanel(
				telemetry,
				extensionUri,
				activeColumn || vscode.ViewColumn.Active,
				title,
				folderRepositoryManager,
				undefined,
				existingPanel,
				undefined
			);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants